Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

fix: Github Action handles endpoints ending in / #249

Merged
merged 24 commits into from
Aug 17, 2020
Merged

fix: Github Action handles endpoints ending in / #249

merged 24 commits into from
Aug 17, 2020

Conversation

StuartRucker
Copy link
Contributor

Used the url npm library resolve function to handle when the inputted URL ends in a slash, since you need to append the post endpoint `/api/build/gh/v1'

@google-cla google-cla bot added the cla: yes label Aug 14, 2020
@@ -13,7 +13,8 @@
"@actions/core": "^1.2.4",
"@actions/github": "^3.0.0",
"node-fetch": "^2.6.0",
"tap-parser": "^10.0.1"
"tap-parser": "^10.0.1",
"url": "^0.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no need for this dep, url is built into Node.js with the exact same method signature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@bcoe bcoe merged commit 78b0d7a into master Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants